Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify FromIterator example of Result #42569

Merged
merged 1 commit into from
Jun 11, 2017
Merged

Conversation

birkenfeld
Copy link
Contributor

The previous version may be clearer for newcomers, but this is how you'd write it idiomaticly.

@rust-highfive
Copy link
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@frewsxcv
Copy link
Member

Agreed this is more idiomatic and requires a little more background on knowledge (mainly the checked_add method) but I still think this is an improvement, thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 11, 2017

📌 Commit 496bd63 has been approved by frewsxcv

@bors
Copy link
Collaborator

bors commented Jun 11, 2017

⌛ Testing commit 496bd63 with merge 07a2dd4...

bors added a commit that referenced this pull request Jun 11, 2017
Simplify FromIterator example of Result

The previous version may be clearer for newcomers, but this is how you'd write it idiomaticly.
@Mark-Simulacrum Mark-Simulacrum added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 11, 2017
@bors
Copy link
Collaborator

bors commented Jun 11, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: frewsxcv
Pushing 07a2dd4 to master...

@bors bors merged commit 496bd63 into rust-lang:master Jun 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants